[webkit-reviews] review granted: [Bug 136682] Web Inspector: Fix ESLint consistent-return warnings : [Attachment 237863] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 136682: Web Inspector: Fix ESLint consistent-return warnings
https://bugs.webkit.org/show_bug.cgi?id=136682

Attachment 237863: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=237863&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237863&action=review


> Source/WebInspectorUI/UserInterface/Controllers/FrameResourceManager.js:-389
>	   console.assert(!this._waitingForMainFrameResourceTreePayload);
> -	   if (this._waitingForMainFrameResourceTreePayload)
> -	       return;

Why isn't the early return needed still? It would be bad to continue here.