[webkit-reviews] review denied: [Bug 135353] Use CSS3 Decorating Box concept to determine thickness for text decorations : [Attachment 235617] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has denied Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 135353: Use CSS3 Decorating Box concept to determine thickness for text
decorations
https://bugs.webkit.org/show_bug.cgi?id=135353

Attachment 235617: Patch
https://bugs.webkit.org/attachment.cgi?id=235617&action=review

------- Additional Comments from Myles C. Maxfield <mmaxfield at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235617&action=review


> Source/WebCore/rendering/InlineTextBox.h:187
> +    const InlineFlowBox* m_decoratingBox;

This blows up the size by a significant amount. See if the performance hit of
computing this when it is needed is too high.