[webkit-reviews] review granted: [Bug 136654] Clean up some ENABLE(PICTURE_SIZES) stuff, don't change function signatures inside #ifdefs : [Attachment 237828] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 136654: Clean up some ENABLE(PICTURE_SIZES) stuff, don't change function
signatures inside #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=136654

Attachment 237828: Patch
https://bugs.webkit.org/attachment.cgi?id=237828&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237828&action=review


> Source/WebCore/html/parser/HTMLDocumentParser.cpp:329
> +	   m_preloadScanner->scan(m_preloader.get(),
document()->baseElementURL(), document()->renderView(), document()->frame());

Seems bizarre to pass both a RenderView* and a Frame*. Why not just pass a
Document& instead? It seems to me that SourceSizeList::parseSizesAttribute
should also just take a Document&. And the same for every level in between.