[webkit-reviews] review granted: [Bug 136436] REGRESSION(r173031): crashes during run-layout-jsc on x86/Linux : [Attachment 237640] Updated patch after discussion with ggaren

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 136436: REGRESSION(r173031): crashes during run-layout-jsc on x86/Linux
https://bugs.webkit.org/show_bug.cgi?id=136436

Attachment 237640: Updated patch after discussion with ggaren
https://bugs.webkit.org/attachment.cgi?id=237640&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237640&action=review


r=me

> Source/JavaScriptCore/ChangeLog:10
> +	   That stack pointer provides space for the worse case number of
stacked

"worst"

> Source/JavaScriptCore/jit/JITOperations.cpp:-615
> -    execCallee->setCallerFrame(exec);

Does the LLInt need updating to perform this callerFrame store as well, or does
it do so already?