[webkit-reviews] review granted: [Bug 136433] REGRESSION (r172832): Poor 2-finger scrolling performance at theverge.com articles (all tiles repaint) : [Attachment 237607] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 136433: REGRESSION (r172832): Poor 2-finger scrolling performance at
theverge.com articles (all tiles repaint)
https://bugs.webkit.org/show_bug.cgi?id=136433

Attachment 237607: Patch
https://bugs.webkit.org/attachment.cgi?id=237607&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237607&action=review


> Source/WebCore/rendering/RenderLayer.cpp:6401
> +    bool needsHorizontalScrollbar = renderer().hasOverflowClip() &&
((hasHorizontalScrollbar() && overflowDefinesAutomaticScrollbar(overflowX)) ||
overflowRequiresScrollbar(overflowX));

we already have our RenderBox in a local, perhaps use that instead?

>>
LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/root-overflow-with-mousewh
eel.html:35
>> +	setTimeout(checkForScroll, 500);
> 
> Oh, I can get rid of this setTimeout completely, so that's good.

Please do! 500ms tests are unwelcome :)