[webkit-reviews] review granted: [Bug 137770] Various crashes in ViewGestureControllerIOS when closing a tab while a swipe gesture is in progress : [Attachment 239935] patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 137770: Various crashes in ViewGestureControllerIOS when closing a tab
while a swipe gesture is in progress
https://bugs.webkit.org/show_bug.cgi?id=137770

Attachment 239935: patch
https://bugs.webkit.org/attachment.cgi?id=239935&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=239935&action=review


> Source/WebKit2/UIProcess/ios/ViewGestureControllerIOS.mm:97
> +    _backTransitionController = nullptr;
> +    _forwardTransitionController = nullptr;

Isn’t nil more appropriate for these, since the underlying type is an id?

I’m not convinced that we should clear these. Doing so doesn’t really guarantee
anything except that if -directionForTransition: were to be called it would
return the wrong answer.