[webkit-reviews] review requested: [Bug 137779] [iOS] Crashes in CFURLConnection delegates due to unimplemented retain/release : [Attachment 239950] proposed fix

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 137779: [iOS] Crashes in CFURLConnection delegates due to unimplemented
retain/release
https://bugs-test.webkit.org/show_bug.cgi?id=137779

Attachment 239950: proposed fix

https://bugs-test.webkit.org/attachment.cgi?id=239950&action=review




--- Description ---
We need ResourceHandleCFURLConnectionDelegate to remain alive for as long as
CFURLConnection is making delegate calls. The only way to guarantee this is to
have CFURLConnection retain the delegate, which it does - but we don't
implement retain/release client callbacks!

This causes crashes in Networking process.

--- Comment #1 from Alexey Proskuryakov <ap at webkit.org> ---
*** Bug 135027 has been marked as a duplicate of this bug. ***

--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
rdar://problem/18679320