[webkit-reviews] review granted: [Bug 137602] Add test to check stretchy value is case sensitive : [Attachment 239611] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alejandro G. Castro
<alex at igalia.com>'s request for review:
Bug 137602: Add test to check stretchy value is case sensitive
https://bugs.webkit.org/show_bug.cgi?id=137602

Attachment 239611: patch
https://bugs.webkit.org/attachment.cgi?id=239611&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Two thoughts:

1) We should also check that "false" is case sensitive. I presume there is some
case where the default for stretchy is true, and "false" changes it back to
false, but "False" does not.

2) Tests that explain what the results should look like are generally better
than tests that don't. Even though this is a reference test it would be nice if
it was self-explanatory in the browser. In many cases I put expected results in
the original as well as the expected file so a human being can compare things
visually, and then put the expected result twice in the expected.html file. For
example, fast/text/international/old-turkic-direction.html takes that approach.