[webkit-reviews] review granted: [Bug 137595] Use is<>() / downcast<>() for GraphicsLayer subclasses : [Attachment 239627] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 10 09:43:04 PDT 2014
Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 137595: Use is<>() / downcast<>() for GraphicsLayer subclasses
https://bugs.webkit.org/show_bug.cgi?id=137595
Attachment 239627: Patch
https://bugs.webkit.org/attachment.cgi?id=239627&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=239627&action=review
> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3200
> size_t numChildren = childLayers.size();
> for (size_t i = 0; i < numChildren; ++i) {
Should use a modern for loop.
> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3203
> clonalSublayers.append(childLayer);
Should be childLayer.release().
More information about the webkit-reviews
mailing list