[webkit-reviews] review granted: [Bug 136692] [GTK] Race condition with WebKitWebView:is-loading after starting page load : [Attachment 238303] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 136692: [GTK] Race condition with WebKitWebView:is-loading after starting
page load
https://bugs.webkit.org/show_bug.cgi?id=136692

Attachment 238303: Patch
https://bugs.webkit.org/attachment.cgi?id=238303&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=238303&action=review


LGTM, thanks!

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1590
> +    if (isDelayedEvent) {
> +	   if (loadEvent == WEBKIT_LOAD_COMMITTED)
> +	       webView->priv->waitingForMainResource = false;
> +	   else if (loadEvent == WEBKIT_LOAD_FINISHED) {
> +	       // Manually set is-loading again in case a new load was started.

> +	       webkitWebViewSetIsLoading(webView,
getPage(webView)->pageLoadState().isLoading());
> +	   }
> +    }

Is there a reason not to do these checks in the if/else if block above? Do they
need to come after the load changed signal emission?