[webkit-reviews] review granted: [Bug 137526] [Win] Resolve various static analyzer warnings in WebCore : [Attachment 239480] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 137526: [Win] Resolve various static analyzer warnings in WebCore
https://bugs.webkit.org/show_bug.cgi?id=137526

Attachment 239480: Patch
https://bugs.webkit.org/attachment.cgi?id=239480&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=239480&action=review


>> Source/WebCore/page/SessionIDHash.h:45
>> +	static void constructDeletedValue(WebCore::SessionID& slot) { slot =
WebCore::SessionID(static_cast<uint64_t>(-2)); }
> 
> This is confusing even though I know it's correct. Perhaps this is worth
pulling out the -2 into a static const variable, and maybe setting it to
something like 0xFFFFFFFFFFFFFFFE

I agree with Myles that it is weird looking.