[webkit-reviews] review granted: [Bug 137242] DFG SSA should use PutLocal/KillLocal instead of SetLocal to communicate what is flushed to the stack and when : [Attachment 238988] the patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 137242: DFG SSA should use PutLocal/KillLocal instead of SetLocal to
communicate what is flushed to the stack and when
https://bugs.webkit.org/show_bug.cgi?id=137242

Attachment 238988: the patch
https://bugs.webkit.org/attachment.cgi?id=238988&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238988&action=review


r=me

> Source/JavaScriptCore/ChangeLog:36
> +	   - PutLocal means that that a value is to be stored to the stack. It
makes a flush available.
> +	   - KillLocal means that the value stored to the stack is no longer
available for the purposes
> +	     of OSR (i.e. it no longer accurately corresponds to what that
actual bytecode variable
> +	     would have been, so you have to fall back on node availability).

I wonder if we can get the flush logic into the names of these nodes.

FlushLocal
KillFlushLocal

?