[webkit-reviews] review denied: [Bug 137279] Fixed the Inspector to be able to properly distinguish between scope types : [Attachment 238980] the patch.

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 137279: Fixed the Inspector to be able to properly distinguish between
scope types
https://bugs.webkit.org/show_bug.cgi?id=137279

Attachment 238980: the patch.
https://bugs.webkit.org/attachment.cgi?id=238980&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238980&action=review


> Source/JavaScriptCore/runtime/JSNameScope.h:70
> +	   m_isCatchScope = !!(attributes & CatchScope);

It's a bad abstraction to use a property attribute to discover that an object
is a catch scope. The two abstractions are unrelated, and relating them makes
for spaghetti code.

Instead, you should use an explicit parameter to the JSNameScope constructor.
The VM knows when it allocates a catch scope, and it only does so in a few
places.