[webkit-reviews] review granted: [Bug 133375] Replace uses of CrossThreadTask in DefaultSharedWorkerRepository, WorkerMessagingProxy with C++11 lambdas : [Attachment 232241] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 133375: Replace uses of CrossThreadTask in DefaultSharedWorkerRepository,
WorkerMessagingProxy with C++11 lambdas
https://bugs.webkit.org/show_bug.cgi?id=133375

Attachment 232241: Patch
https://bugs.webkit.org/attachment.cgi?id=232241&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232241&action=review


Looks good. I’d like to eliminate the context argument to the function at some
point. I don’t think it adds much over a function with no arguments.

> Source/WebCore/workers/DefaultSharedWorkerRepository.cpp:188
> +	       context->reportException(errorMessageCopy, lineNumber,
columnNumber, sourceURLCopy);

Need to add a nullptr to this line, after sourceURLCopy.

> Source/WebCore/workers/WorkerMessagingProxy.cpp:170
> +	   if (this->askedToTerminate())

No need for "this->" here.

> Source/WebCore/workers/WorkerMessagingProxy.cpp:238
> +	  
toWorkerGlobalScope(context)->workerInspectorController().disconnectFrontend(In
spector::InspectorDisconnectReason::InspectorDestroyed);

Could we just capture a worker global scope here instead of casting the
context?