[webkit-reviews] review granted: [Bug 133374] Pass C++11 lambdas to callOnMainThread() calls in IconDatabase : [Attachment 232240] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 133374: Pass C++11 lambdas to callOnMainThread() calls in IconDatabase
https://bugs.webkit.org/show_bug.cgi?id=133374

Attachment 232240: Patch
https://bugs.webkit.org/attachment.cgi?id=232240&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232240&action=review


> Source/WebCore/loader/icon/IconDatabase.cpp:2160
> +    ImportedIconURLForPageURLWorkItem* itemPtr = new
ImportedIconURLForPageURLWorkItem(m_client, pageURL);

Does this allocation need to be done in the icon sync thread? Can it be done on
the main thread instead?

> Source/WebCore/loader/icon/IconDatabase.cpp:2171
> +    ImportedIconDataForPageURLWorkItem* itemPtr = new
ImportedIconDataForPageURLWorkItem(m_client, pageURL);

Does this allocation need to be done in the icon sync thread? Can it be done on
the main thread instead?

> Source/WebCore/loader/icon/IconDatabase.cpp:2182
> +    RemovedAllIconsWorkItem* itemPtr = new
RemovedAllIconsWorkItem(m_client);

Does this allocation need to be done in the icon sync thread? Can it be done on
the main thread instead?

> Source/WebCore/loader/icon/IconDatabase.cpp:2193
> +    FinishedURLImport* itemPtr = new FinishedURLImport(m_client);

Does this allocation need to be done in the icon sync thread? Can it be done on
the main thread instead?