[webkit-reviews] review granted: [Bug 133410] Address some review comments on bug 133408 : [Attachment 232306] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 30 15:32:11 PDT 2014


Anders Carlsson <andersca at apple.com> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 133410: Address some review comments on bug 133408
https://bugs.webkit.org/show_bug.cgi?id=133410

Attachment 232306: Patch
https://bugs.webkit.org/attachment.cgi?id=232306&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232306&action=review


> Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegate.h:64
> + for identifying the controlling website is [[[frame request] URL] host].

Please use property syntax, i.e. frame.request.URL.host.

> Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegate.h:78
> + for identifying the controlling website is [[[frame request] URL] host].

Please use property syntax, i.e. frame.request.URL.host.

> Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegate.h:93
> + for identifying the controlling website is [[[frame request] URL] host].

Please use property syntax, i.e. frame.request.URL.host.


More information about the webkit-reviews mailing list