[webkit-reviews] review granted: [Bug 133364] [iOS][WK2] When a page does not finish rotation before the end of the animation, synchronize explicitly : [Attachment 232268] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 133364: [iOS][WK2] When a page does not finish rotation before the end of
the animation, synchronize explicitly
https://bugs.webkit.org/show_bug.cgi?id=133364

Attachment 232268: Patch
https://bugs.webkit.org/attachment.cgi?id=232268&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=232268&action=review


> Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:257
> +    if (m_dynamicViewportSizeUpdateInProgress) {
> +	   m_dynamicViewportSizeUpdateInProgress = false;
> +	   double newScale;
> +	   FloatPoint newScrollPosition;
> +	   if
(m_process->sendSync(Messages::WebPage::SynchronizeDynamicViewportUpdate(),
Messages::WebPage::SynchronizeDynamicViewportUpdate::Reply(newScale,
newScrollPosition), m_pageID, std::chrono::seconds(2))) {
> +	       m_pageClient.dynamicViewportUpdateChangedTarget(newScale,
newScrollPosition);
> +
> +	      
m_process->connection()->waitForAndDispatchImmediately<Messages::RemoteLayerTre
eDrawingAreaProxy::CommitLayerTree>(m_pageID, std::chrono::seconds(1));
> +	   }
> +    }
> +}

I would add a comment (and bugzilla link?) about how we could do this without a
sync message in the future using transactions.