[webkit-reviews] review granted: [Bug 87846] vw/vh units used as font/line-height values don't scale with the viewport : [Attachment 232152] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 27 16:41:24 PDT 2014


Darin Adler <darin at apple.com> has granted Bem Jones-Bey <bjonesbe at adobe.com>'s
request for review:
Bug 87846: vw/vh units used as font/line-height values don't scale with the
viewport
https://bugs.webkit.org/show_bug.cgi?id=87846

Attachment 232152: Patch
https://bugs.webkit.org/attachment.cgi?id=232152&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232152&action=review


> Source/WebCore/css/CSSGradientValue.cpp:1120
> +    addStops(*gradient,  conversionData, maxExtent);

Extra space here after the comma.

> Source/WebCore/css/CSSToLengthConversionData.h:34
> +#include "IntSize.h"

Why are we adding this include? I don’t see anything new in the header that
seems to be using it.


More information about the webkit-reviews mailing list