[webkit-reviews] review granted: [Bug 133327] run web timing tests : [Attachment 232158] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 133327: run web timing tests
https://bugs.webkit.org/show_bug.cgi?id=133327

Attachment 232158: Patch
https://bugs.webkit.org/attachment.cgi?id=232158&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=232158&action=review


> LayoutTests/fast/dom/script-tests/webtiming-document-open.js:34
> +    for (var key in timing) {
> +	   keys.push(key);
> +    }

No curly brackets for single line statements.

> LayoutTests/fast/dom/script-tests/webtiming-navigate-within-document.js:11
> +    for (var property in timing) {
> +	   properties.push(property);
> +    }

Ditto.

> LayoutTests/platform/mac/TestExpectations:193
> +# Resource Timing is not enabled.
> +# https://bugs.webkit.org/show_bug.cgi?id=133321
>  http/tests/w3c/webperf

Shouldn't we also disable this on ML and Mavericks?