[webkit-reviews] review granted: [Bug 132902] [EFL][WK2] Fix an unit test of ewk_context_url_scheme_register() : [Attachment 231477] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 132902: [EFL][WK2] Fix an unit test of ewk_context_url_scheme_register()
https://bugs.webkit.org/show_bug.cgi?id=132902

Attachment 231477: Patch
https://bugs.webkit.org/attachment.cgi?id=231477&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231477&action=review


> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context.cpp:128
> +#if ENABLE(CUSTOM_PROTOCOL)
>      ewk_context_url_scheme_register(ewk_view_context_get(webView()),
"fooscheme", schemeRequestCallback, 0);
> -    ASSERT_TRUE(loadUrlSync("fooscheme:MyPath"));
> -    ASSERT_STREQ("Foo", ewk_view_title_get(webView()));
> +    ewk_view_url_set(webView(), "fooscheme:MyPath");
> +
> +    ASSERT_TRUE(waitUntilTrue(finishTest, testTimeoutSeconds));
> +#else
> +    ewk_context_url_scheme_register(ewk_view_context_get(webView()),
"fooscheme", schemeRequestCallback, 0);
> +    ewk_view_url_set(webView(), "fooscheme:MyPath");
> +
> +    ASSERT_FALSE(waitUntilTrue(finishTest, testTimeoutSeconds));
> +#endif

Does the test even need to run at all when custom protocols are disabled? I'd
just put the entire test inside #if ENABLE(CUSTOM_PROTOCOL) and get rid of the
#else block.