[webkit-reviews] review granted: [Bug 132922] Move subframe name getter lookup later in JSDOMWindow::getOwnPropertySlot : [Attachment 231476] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 132922: Move subframe name getter lookup later in
JSDOMWindow::getOwnPropertySlot
https://bugs.webkit.org/show_bug.cgi?id=132922

Attachment 231476: Patch
https://bugs.webkit.org/attachment.cgi?id=231476&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231476&action=review


r=me

> Source/WebCore/ChangeLog:15
> +	   Mozilla no longer implements this behavior. Instead, they do the
lookup on the prototype before 
> +	   looking for subframe name getters. We should change this to match
Mozilla. This has the convenient 
> +	   side effect of allowing us to cache lookups in the window's
prototype chain.

FWIW, I think Mozilla and WebIDL technically specify that name getters should
exist in the prototype chain between the window prototype and the object
prototype. So, eventually, we'll want to do that, and verify that a frame named
"toString" takes precedence over Object.prototype.toString.

Still, this patch is a step in the right direction. I don't think I'll let
<iframe name="toString"> stand in our way.