[webkit-reviews] review granted: [Bug 132912] Implement NSSharingServiceDelegate method "transitionImageForShareItem" : [Attachment 231461] Patch v1

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 132912: Implement NSSharingServiceDelegate method
"transitionImageForShareItem"
https://bugs.webkit.org/show_bug.cgi?id=132912

Attachment 231461: Patch v1
https://bugs.webkit.org/attachment.cgi?id=231461&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231461&action=review


> Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:443
> +    buffer->context()->translate(-FloatSize(rect.x(), rect.y()));

-toFloatSize(rect.location())

> Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:444
> +    frameView->paintContents(buffer->context(), IntRect(rect));

is this truncated FloatRect->IntRect right?