[webkit-reviews] review denied: [Bug 132700] Update local storage path : [Attachment 231405] address comments

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Martin Hock <mhock at apple.com>'s
request for review:
Bug 132700: Update local storage path
https://bugs.webkit.org/show_bug.cgi?id=132700

Attachment 231405: address comments
https://bugs.webkit.org/attachment.cgi?id=231405&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231405&action=review


I made some comments below, but then we talked and realized that this is not
the right place for this code.

> Source/WebKit/mac/Storage/WebStorageManager.mm:38
> +#if PLATFORM(IOS)
> +#import <yarr/RegularExpression.h>
> +#endif

This is not needed any more.

> Source/WebKit/mac/Storage/WebStorageManager.mm:44
> +#if PLATFORM(IOS)
> +using JSC::Yarr::RegularExpression;
> +#endif

Neither is this.

> Source/WebKit/mac/Storage/WebStorageManager.mm:55
> +static bool isHex(const String& str, size_t indexStart, size_t indexEnd)

We have a function for this, isASCIIHexDigit() in ASCIICType.h.