[webkit-reviews] review granted: [Bug 132647] Replace DEPRECATED_DEFINE_STATIC_LOCAL by static NeverDestroyed<T> in svg/ : [Attachment 230997] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 132647: Replace DEPRECATED_DEFINE_STATIC_LOCAL by static NeverDestroyed<T>
in svg/
https://bugs.webkit.org/show_bug.cgi?id=132647

Attachment 230997: Patch
https://bugs.webkit.org/attachment.cgi?id=230997&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230997&action=review


Seems like there is an inefficient pattern here of all these sets, but thanks
for modernizing the idiom at least.

> Source/WebCore/svg/SVGUseElement.cpp:60
> +#include <wtf/NeverDestroyed.h>

This should be up above with the #includes (at the bottom of them), not here
down below the commented-out #defines.