[webkit-reviews] review granted: [Bug 123665] jsmin.py license header confusing, mentions non-free license : [Attachment 230999] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alberto Garcia <berto at igalia.com>'s
request for review:
Bug 123665: jsmin.py license header confusing, mentions non-free license
https://bugs.webkit.org/show_bug.cgi?id=123665

Attachment 230999: Patch
https://bugs.webkit.org/attachment.cgi?id=230999&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230999&action=review


> Source/JavaScriptCore/ChangeLog:27
> +	   (jsmin):
> +	   (JavascriptMinify):
> +	   (JavascriptMinify.__init__):
> +	   (JavascriptMinify.minify):
> +	   (JavascriptMinify.minify.write):
> +	   (isAlphanum): Deleted.
> +	   (UnterminatedComment): Deleted.
> +	   (UnterminatedStringLiteral): Deleted.
> +	   (UnterminatedRegularExpression): Deleted.
> +	   (JavascriptMinify._outA): Deleted.
> +	   (JavascriptMinify._outB): Deleted.
> +	   (JavascriptMinify._get): Deleted.
> +	   (JavascriptMinify._peek): Deleted.
> +	   (JavascriptMinify._next): Deleted.
> +	   (JavascriptMinify._action): Deleted.
> +	   (JavascriptMinify._jsmin): Deleted.

You shouldn’t leave this function list in the change log in a case like this.