[webkit-reviews] review granted: [Bug 132633] Dragging text from one paragraph to another does not render as expected : [Attachment 230954] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 132633: Dragging text from one paragraph to another does not render as
expected
https://bugs.webkit.org/show_bug.cgi?id=132633

Attachment 230954: Patch
https://bugs.webkit.org/attachment.cgi?id=230954&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230954&action=review


> Source/WebCore/editing/ReplaceSelectionCommand.cpp:633
> +	       if (paragraphElement &&
paragraphElement->parentNode()->hasEditableStyle())

Do we have an ironclad guarantee that paragraphElement->parentNode() is
non-null? No way it could have been removed from its parent during the editing
process?