[webkit-reviews] review granted: [Bug 132407] Calling createPattern with a broken image must throw an invalidstate error : [Attachment 230949] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 6 17:58:33 PDT 2014
Darin Adler <darin at apple.com> has granted Rik Cabanier <cabanier at adobe.com>'s
request for review:
Bug 132407: Calling createPattern with a broken image must throw an
invalidstate error
https://bugs.webkit.org/show_bug.cgi?id=132407
Attachment 230949: Patch
https://bugs.webkit.org/attachment.cgi?id=230949&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230949&action=review
> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:1756
> + if (!cachedImage || cachedImage->status() == CachedResource::LoadError)
{
Does the test case cover the "!cachedImage" case or only the LoadError case?
More information about the webkit-reviews
mailing list