[webkit-reviews] review denied: [Bug 121548] [SOUP] TLSErrors do not cause page load to fail when not ignored : [Attachment 230480] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 3 04:26:25 PDT 2014


Carlos Garcia Campos <cgarcia at igalia.com> has denied  review:
Bug 121548: [SOUP] TLSErrors do not cause page load to fail when not ignored
https://bugs.webkit.org/show_bug.cgi?id=121548

Attachment 230480: Patch
https://bugs.webkit.org/attachment.cgi?id=230480&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
hmm, after trying the patch I've realized that this is not the right fix. This
patch is setting the tls errors to the response after the redirection, which is
not even a HTTPS response. I think we should fail *before* the redirection, so
that we don't see the redirected URL in the browser either.


More information about the webkit-reviews mailing list