[webkit-reviews] review granted: [Bug 130188] [GTK][CMake] Unable to do make install : [Attachment 230556] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 130188: [GTK][CMake] Unable to do make install
https://bugs.webkit.org/show_bug.cgi?id=130188

Attachment 230556: Patch
https://bugs.webkit.org/attachment.cgi?id=230556&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230556&action=review


> Source/cmake/OptionsGTK.cmake:20
> +set(ENABLE_GTKDOC OFF CACHE BOOL "Whether or not to use generate gtkdoc.")

hmm, we use generate-gtkdoc even when this is off no? This actually to decide
whether to call generate-gtkdoc with --skip-html or not, right? Please improve
this message before landing to avoid confusions.