[webkit-reviews] review canceled: [Bug 131758] Session-aware plugin autostart data : [Attachment 230587] rebase
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 1 18:10:27 PDT 2014
Martin Hock <mhock at apple.com> has canceled Martin Hock <mhock at apple.com>'s
request for review:
Bug 131758: Session-aware plugin autostart data
https://bugs.webkit.org/show_bug.cgi?id=131758
Attachment 230587: rebase
https://bugs.webkit.org/attachment.cgi?id=230587&action=review
------- Additional Comments from Martin Hock <mhock at apple.com>
I noticed a bug in my last patch which Alexey helped me find the root cause of
- thanks! The bug was in the implementation of
PlugInAutoStartProvider::addAutoStartOriginHash. I'm not convinced that the new
implementation is the nicest way to write it, but it does seem to work, at
least. I repeat myself in two different branches in order to avoid doing
redundant hash lookups. I'd appreciate any opinions on my hash travails!
More information about the webkit-reviews
mailing list