[webkit-reviews] review granted: [Bug 132452] Update service picker API usage : [Attachment 230635] Patch v1

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 132452: Update service picker API usage
https://bugs.webkit.org/show_bug.cgi?id=132452

Attachment 230635: Patch v1
https://bugs.webkit.org/attachment.cgi?id=230635&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230635&action=review


> Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:113
> +	   data = [nsImage.get() TIFFRepresentation];

no .get()

> Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:166
> +	   [self didShareImageData :[item TIFFRepresentation]
confirmDataIsValidTIFFData:NO];

colon is in way the wrong place

> Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:169
> +	   NSString *itemUTI =
itemProvider.registeredTypeIdentifiers.firstObject;

firstObject is not available on ML IIRC

> Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:370
> +	   RetainPtr<CFDataRef> cfdata = data->createCFData();

capital D