[webkit-reviews] review granted: [Bug 130626] [WK2] Make updates on ViewUpdateDispatcher less heavy : [Attachment 227520] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 130626: [WK2] Make updates on ViewUpdateDispatcher less heavy
https://bugs.webkit.org/show_bug.cgi?id=130626

Attachment 227520: Patch
https://bugs.webkit.org/attachment.cgi?id=227520&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227520&action=review


> Source/WebKit2/WebProcess/WebPage/ViewUpdateDispatcher.cpp:74
>	   localCopy.swap(m_latestUpdate);

This should really use std::move instead of swap. Swap was the hack for doing
this before we had move assignment.

Also, the code below uses the word “iterator”  strangely. It should be written
like this:

    for (uint64_t pageID : localCopy.keys())