[webkit-reviews] review granted: [Bug 130631] [iOS][WK2] Micro-optimize view state updates on the UIProcess side : [Attachment 227528] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 130631: [iOS][WK2] Micro-optimize view state updates on the UIProcess side
https://bugs.webkit.org/show_bug.cgi?id=130631

Attachment 227528: Patch
https://bugs.webkit.org/attachment.cgi?id=227528&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227528&action=review


> Source/WebKit2/UIProcess/ios/WKContentView.mm:240
> +    return
(FloatRect)FrameView::rectForViewportConstrainedObjects(enclosingLayoutRect(uno
bscuredRect), roundedLayoutSize(FloatSize(documentSize)), scale, false,
StickToViewportBounds);

What is the (FloatRect) here for? Doesn’t this compile without it?

Also, why FloatSize(documentSize)? Doesn’t this compile without the explicit
FloatSize()?