[webkit-reviews] review granted: [Bug 124508] Crash when BytecodeGenerator::emitJump calls Label::bind on null pointer : [Attachment 227503] the patch.

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 124508: Crash when BytecodeGenerator::emitJump calls Label::bind on null
pointer
https://bugs.webkit.org/show_bug.cgi?id=124508

Attachment 227503: the patch.
https://bugs.webkit.org/attachment.cgi?id=227503&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227503&action=review


r+ with operator! vs. bool fixed

> Source/JavaScriptCore/bytecompiler/LabelScope.h:121
> +

i would prefer operator! or at the very least make this explicit other c++ can
use this to convert to ints, which has historically been a source of much pain