[webkit-reviews] review granted: [Bug 130621] [iOS] clean up fullscreen player controller when exiting fullscreen : [Attachment 227502] Proposed patch.

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 130621: [iOS] clean up fullscreen player controller when exiting fullscreen
https://bugs.webkit.org/show_bug.cgi?id=130621

Attachment 227502: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=227502&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227502&action=review


r=me with nits.

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:207
> +    if (_avPlayerController && [_avPlayerController delegate])

This should be unnecessary.  If _avPlayerController is nil,
[_avPlayerController delegate] will return nil as well.

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:215
> +    if (!_avPlayerController || ![_avPlayerController delegate])

Ditto.