[webkit-reviews] review granted: [Bug 128261] GC timer should intelligently choose between EdenCollections and FullCollections : [Attachment 227142] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 19 13:30:35 PDT 2014


Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 128261: GC timer should intelligently choose between EdenCollections and
FullCollections
https://bugs.webkit.org/show_bug.cgi?id=128261

Attachment 227142: Patch
https://bugs.webkit.org/attachment.cgi?id=227142&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227142&action=review


r=me

> Source/JavaScriptCore/heap/EdenGCActivityCallback.cpp:57
> +    return double(sizeBefore - sizeAfter) / double(sizeBefore);

static_cast<double> is more our style.


More information about the webkit-reviews mailing list