[webkit-reviews] review granted: [Bug 130452] Improving webkitGetUserMedia error handling and error messages : [Attachment 227206] Requested changes

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Thiago de Barros Lacerda
<thiago.lacerda at openbossa.org>'s request for review:
Bug 130452: Improving webkitGetUserMedia error handling and error messages
https://bugs.webkit.org/show_bug.cgi?id=130452

Attachment 227206: Requested changes
https://bugs.webkit.org/attachment.cgi?id=227206&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227206&action=review


> Source/WebCore/bindings/js/JSNavigatorCustom.cpp:58
> +	   throwVMError(exec, createTypeError(exec, "Argument 2
('successCallback') to Navigator.webkitGetUserMedia must be a function"));

"to Navigator.webkitGetUserMedia must be a function" is common to both error
messages, you should split this:

"Argument 2 ('successCallback')", "to Navigator.webkitGetUserMedia must be a
function"

> Source/WebCore/bindings/js/JSNavigatorCustom.cpp:66
> +	       throwVMError(exec, createTypeError(exec, "Argument 3
('errorCallback') to Navigator.webkitGetUserMedia must be a function"));

And this:

"Argument 3 ('errorCallback')", "to Navigator.webkitGetUserMedia must be a
function"