[webkit-reviews] review granted: [Bug 130363] Add transparent window support back into MiniBrowser : [Attachment 226968] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 17 16:43:36 PDT 2014


Anders Carlsson <andersca at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 130363: Add transparent window support back into MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=130363

Attachment 226968: Patch
https://bugs.webkit.org/attachment.cgi?id=226968&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226968&action=review


> Tools/MiniBrowser/mac/WK2BrowserWindowController.m:257
> +    [[self window] setOpaque:!isTransparent];
> +    [[self window] setHasShadow:!isTransparent];

I think you should use dot notation here.


More information about the webkit-reviews mailing list