[webkit-reviews] review denied: [Bug 130348] [WK2] Getting rid of compilation warnings : [Attachment 226936] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 17 16:36:18 PDT 2014
Benjamin Poulain <benjamin at webkit.org> has denied Thiago de Barros Lacerda
<thiago.lacerda at openbossa.org>'s request for review:
Bug 130348: [WK2] Getting rid of compilation warnings
https://bugs.webkit.org/show_bug.cgi?id=130348
Attachment 226936: Patch
https://bugs.webkit.org/attachment.cgi?id=226936&action=review
------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=226936&action=review
> Source/WebKit2/UIProcess/API/C/WKPage.cpp:705
> + UNUSED_PARAM(navigationID);
> if (!m_client.didStartProvisionalLoadForFrame)
In the implementation, you remove the name of the input argument instead of
using UNUSED_PARAM().
For example, in this case, you should just remove navigationID.
More information about the webkit-reviews
mailing list