[webkit-reviews] review denied: [Bug 130312] Use an anonymous union of std::unique_ptr members in SVGAnimatedType : [Attachment 226861] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Zan Dobersek <zandobersek at gmail.com>'s
request for review:
Bug 130312: Use an anonymous union of std::unique_ptr members in
SVGAnimatedType
https://bugs.webkit.org/show_bug.cgi?id=130312

Attachment 226861: Patch
https://bugs.webkit.org/attachment.cgi?id=226861&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226861&action=review


> Source/WebCore/ChangeLog:10
> +	   Make the union in SVGAnimatedType anonymous. The members of the
union are now
> +	   std::unique_ptr objects instead of raw pointers, enabling simply
moving the
> +	   passed-in std::unique_ptr objects in create*() methods.

Great idea, but looks like the Windows compiler does not support this advanced
C++ feature yet.

Can’t do this unless we solve this problem on Windows.