[webkit-reviews] review granted: [Bug 130315] CSSValueList should assert that no null values are added to it. : [Attachment 226865] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Mar 16 19:25:32 PDT 2014
Darin Adler <darin at apple.com> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 130315: CSSValueList should assert that no null values are added to it.
https://bugs.webkit.org/show_bug.cgi?id=130315
Attachment 226865: Patch
https://bugs.webkit.org/attachment.cgi?id=226865&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226865&action=review
Bot says:
Regressions: Unexpected crashes (1)
mathml/wbr-in-mroot-crash.html [ Crash ]
r=me if you look into that
> Source/WebCore/css/CSSValueList.h:58
> + void append(PassRefPtr<CSSValue> value);
> + void prepend(PassRefPtr<CSSValue> value);
Like the style bot says, you should remove the argument names here.
More information about the webkit-reviews
mailing list