[webkit-reviews] review granted: [Bug 129841] [EME] Extend the lifetime of MediaKeySession. : [Attachment 226057] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 129841: [EME] Extend the lifetime of MediaKeySession.
https://bugs.webkit.org/show_bug.cgi?id=129841

Attachment 226057: Patch
https://bugs.webkit.org/attachment.cgi?id=226057&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226057&action=review


Is it possible to add a test for this?

> Source/WebCore/Modules/encryptedmedia/MediaKeySession.h:74
> +    virtual bool hasPendingActivity() const override { return (!isClosed()
&& m_keys) || m_asyncEventQueue.hasPendingEvents(); }

Nit: I think "m_keys && !isClosed()" is slightly easier to understand.