[webkit-reviews] review granted: [Bug 129804] [WebRTC] Updating RTCPeerConnection.idl : [Attachment 226060] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 6 19:49:24 PST 2014


Eric Carlson <eric.carlson at apple.com> has granted Thiago de Barros Lacerda
<thiago.lacerda at openbossa.org>'s request for review:
Bug 129804: [WebRTC] Updating RTCPeerConnection.idl
https://bugs.webkit.org/show_bug.cgi?id=129804

Attachment 226060: Patch
https://bugs.webkit.org/attachment.cgi?id=226060&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226060&action=review


> LayoutTests/fast/mediastream/RTCPeerConnection-statsSelector.html:40
> +		   shouldNotThrow('pc.getStats(statsHandler2, statsError,
pc.getLocalStreams()[0].getVideoTracks()[0])');

If we don't already have tests to check the error callback, please file a bug
so we remember to add them.


More information about the webkit-reviews mailing list