[webkit-reviews] review granted: [Bug 129752] ObjC exception when dropping files into a WKView: drag and drop uses code from WebKit.framework : [Attachment 225897] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 5 12:05:39 PST 2014
Enrica Casucci <enrica at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 129752: ObjC exception when dropping files into a WKView: drag and drop
uses code from WebKit.framework
https://bugs.webkit.org/show_bug.cgi?id=129752
Attachment 225897: Patch
https://bugs.webkit.org/attachment.cgi?id=225897&action=review
------- Additional Comments from Enrica Casucci <enrica at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225897&action=review
Looks good
> Source/WebCore/platform/mac/WebCoreNSURLExtras.mm:722
> + NSURLRequest *request = [[NSURLRequest alloc] initWithURL:URL];
RetainPtr and avoid release?
> Source/WebCore/platform/mac/WebCoreNSURLExtras.mm:920
> + */
Comment style
> Source/WebCore/platform/mac/WebCoreNSURLExtras.mm:934
> + return rangeOfURLScheme(stringByTrimmingWhitespace(string)).location !=
NSNotFound;
Maybe you could use CFStringTrimWhitespace.
More information about the webkit-reviews
mailing list