[webkit-reviews] review granted: [Bug 129747] FTL loadStructure always generates invalid IR : [Attachment 225898] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 5 12:05:35 PST 2014


Mark Hahnenberg <mhahnenberg at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 129747: FTL loadStructure always generates invalid IR
https://bugs.webkit.org/show_bug.cgi?id=129747

Attachment 225898: the patch
https://bugs.webkit.org/attachment.cgi?id=225898&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225898&action=review


r=me

> Source/JavaScriptCore/ftl/FTLOutput.h:210
> +    // are actuall integers. This requires an LLVM pointer. Broadly
speaking, you don't

actually


More information about the webkit-reviews mailing list