[webkit-reviews] review granted: [Bug 129563] DFG and FTL should specialize for and support CompareStrictEq over Misc (i.e. boolean, undefined, or null) : [Attachment 225596] the patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted  review:
Bug 129563: DFG and FTL should specialize for and support CompareStrictEq over
Misc (i.e. boolean, undefined, or null)
https://bugs.webkit.org/show_bug.cgi?id=129563

Attachment 225596: the patch
https://bugs.webkit.org/attachment.cgi?id=225596&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225596&action=review


r=me

> Source/JavaScriptCore/bytecode/SpeculatedType.cpp:405
> +bool speculationsCouldBeEqual(SpeculatedType a, SpeculatedType b)

I think "valuesCouldBeEqual" would be clearer here. The input is speculations,
but the question we're asking is about the run-time values.

> Source/JavaScriptCore/bytecode/SpeculatedType.cpp:421
> +    // If either side could be an object or not, then we could go down some
weird
> +    // effectful path.

I think the effect you're talking about is that we'll do a value or string
conversion on the object. Let's say that: "...then the equality comparison
could call a toString or valueOf conversion, which could return anything".