[webkit-reviews] review requested: [Bug 129524] Web Inspector: debugger statements do not break : [Attachment 225685] patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 3 13:04:25 PST 2014


Mark Lam <mark.lam at apple.com> has asked  for review:
Bug 129524: Web Inspector: debugger statements do not break
https://bugs.webkit.org/show_bug.cgi?id=129524

Attachment 225685: patch 2
https://bugs.webkit.org/attachment.cgi?id=225685&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
The previous patch has a union - struct tree that is a little too complex.  The
result is that the compiler ended up expressing the outermost union as a struct
instead.  In patch2, I flattened the union to only contain an unsigned and a
struct.  With this, the inspector tests are passing again.


More information about the webkit-reviews mailing list