[webkit-reviews] review denied: [Bug 129946] Regression: Session Cookies dropped from Application Cache (Appcache) Manifest Request : [Attachment 232753] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Jeffrey Pfau <jpfau at apple.com>'s
request for review:
Bug 129946: Regression: Session Cookies dropped from Application Cache
(Appcache) Manifest Request
https://bugs.webkit.org/show_bug.cgi?id=129946

Attachment 232753: Patch
https://bugs.webkit.org/attachment.cgi?id=232753&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=232753&action=review


r=me on the test. Can you land it and only enable on Yosemite and later?

> Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp:496
> +   
m_frame->loader().client().cookieStorageCopyRequestHeaderFields(request);

As discussed in person, this is not reliable - CFNetwork would overwrite the
header if it has any cookies (such as from a preceding appcache update, or from
a ping request).