[webkit-reviews] review granted: [Bug 133686] REGRESSION (r169725): Several TextTrackCue tests became very flaky : [Attachment 232954] Proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 12 09:10:12 PDT 2014


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 133686: REGRESSION (r169725): Several TextTrackCue tests became very flaky
https://bugs.webkit.org/show_bug.cgi?id=133686

Attachment 232954: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=232954&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232954&action=review


> Source/WebCore/html/HTMLMediaElement.cpp:1580
> +    LOG(Media, "HTMLMediaElement::textTrackModeChanged - mode = %s",
String(track->mode()).utf8().data());

It would have been helpful when debugging this if logging had included data on
which track was being logged; either the value of |this| or some kind of track
ID.


More information about the webkit-reviews mailing list