[webkit-reviews] review granted: [Bug 133779] [iOS WK2] Give WebKitTestRunner a viewport configuration with initial scale=1 for testing : [Attachment 232925] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 133779: [iOS WK2] Give WebKitTestRunner a viewport configuration with
initial scale=1 for testing
https://bugs.webkit.org/show_bug.cgi?id=133779

Attachment 232925: Patch
https://bugs.webkit.org/attachment.cgi?id=232925&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=232925&action=review


> Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm:247
> +    WebPageProxy *webPageProxy = [_contentView page];

* on the wrong side.

> Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm:248
> +   
webPageProxy->setViewportConfigurationMinimumLayoutSize(WebCore::FloatSize(boun
ds.size));

You should also send setMaximumUnobscuredSize() so that we can use viewport
units.
You could set setViewportConfigurationMinimumLayoutSizeForMinimalUI() but there
is no test for it.

They should all take the same size in this case.

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:2200
> +    if (m_useTestingViewportConfiguration) {
> +	  
m_viewportConfiguration.setDefaultConfiguration(ViewportConfiguration::testingP
arameters());
> +	   return;
> +    }

Shouldn't this be above the case with !frame?